Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [OSM-1024] pnpm dep graph builder #218

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

gemaxim
Copy link
Contributor

@gemaxim gemaxim commented Apr 8, 2024

What this does

Extends functionality with dependency graph builder for pnpm lockfiles with versions 5.x and 6.x (corresponding to pnpm@7 and pnpm@8).

Notes for the reviewer

More information

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2024

CLA assistant check
All committers have signed the CLA.

@gemaxim gemaxim force-pushed the feat/OSM-1024/pnpm-parser branch 2 times, most recently from 317b87f to 45b9480 Compare April 8, 2024 07:36
@gemaxim gemaxim self-assigned this Apr 8, 2024
@gemaxim gemaxim force-pushed the feat/OSM-1024/pnpm-parser branch 2 times, most recently from cd7d94f to d4f3f4a Compare April 8, 2024 08:56
Copy link

@yurinka1 yurinka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done!!!

Left some minor comments, great job!

@gemaxim gemaxim force-pushed the feat/OSM-1024/pnpm-parser branch 10 times, most recently from 1d9aecf to 1605d2d Compare April 8, 2024 12:43
@weyert
Copy link

weyert commented Apr 8, 2024

Great job, it's looking good 👍 I hope my draft PR was a bit helpful :)

You might want to consider to also support lock file v7 is will be the basis for the upcoming pnpm v9. Currently in beta.

You could convert the v7 back into v6 format and use that for the rest of the code.

Check out the added fixtures for pnpm lockfile v5 and pnpm lockfile v6. 'package.json' inputs taken from npm and yarn fixtures and checked for the same expected dependency graph.
pnpm lockfiles do not store bundled dependencies. (related to 2 test cases). Links about this: https://docs.gitlab.com/ee/user/application_security/dependency_scanning/

Yups, that's correct. I added the pnpm support for Gitlab.

@gemaxim gemaxim force-pushed the feat/OSM-1024/pnpm-parser branch 4 times, most recently from b70eaeb to 05f7565 Compare April 9, 2024 08:17
@gemaxim
Copy link
Contributor Author

gemaxim commented Apr 9, 2024

Great job, it's looking good 👍 I hope my draft PR was a bit helpful :)

You might want to consider to also support lock file v7 is will be the basis for the upcoming pnpm v9. Currently in beta.

You could convert the v7 back into v6 format and use that for the rest of the code.

Check out the added fixtures for pnpm lockfile v5 and pnpm lockfile v6. 'package.json' inputs taken from npm and yarn fixtures and checked for the same expected dependency graph.
pnpm lockfiles do not store bundled dependencies. (related to 2 test cases). Links about this: https://docs.gitlab.com/ee/user/application_security/dependency_scanning/

Yups, that's correct. I added the pnpm support for Gitlab.

Thanks @weyert ! 😄 I saw your PR and wanted to link my changes here. Really appreciate your work and taking the time to look over this. As for pnpm v9, I think we'll take it into account once it's not beta, should the new lockfile version not be backwards compatible.

@weyert
Copy link

weyert commented Apr 9, 2024

@gemaxim It's definitely not backward compatible, main reason for the major version bump actually, some of the changes:

@gemaxim gemaxim force-pushed the feat/OSM-1024/pnpm-parser branch 2 times, most recently from 259c460 to bc70348 Compare April 11, 2024 07:14
@gemaxim gemaxim marked this pull request as ready for review April 11, 2024 07:52
@gemaxim gemaxim requested a review from a team as a code owner April 11, 2024 07:52
@gemaxim gemaxim force-pushed the feat/OSM-1024/pnpm-parser branch 8 times, most recently from b881ea2 to 01baca2 Compare April 11, 2024 12:04
@gemaxim gemaxim merged commit 5358814 into master Apr 11, 2024
2 checks passed
@gemaxim gemaxim deleted the feat/OSM-1024/pnpm-parser branch April 11, 2024 12:29
@snyksec
Copy link

snyksec commented Apr 11, 2024

🎉 This PR is included in version 1.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@weyert
Copy link

weyert commented Apr 11, 2024

Great work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants